-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portal solution does not work on mobile when used with react-swipeable-views #463
Comments
Can you please post a recording of this behaviour? I suspect that some touch events are not being shared nicely between the libraries |
@alexreardon Here is a quick screencast. As you can see in the first segment of the video the draggable works fine in desktop mode. The second segment of the video I switch to responsive mode and the draggable can no longer be moved. https://www.useloom.com/share/685d801cd2614d7bb2e152ea2590cf42 |
I am having similar issue. When I put dnd component on the second+ view of the swipeable views they disappear on drag. This is because they show up in the first view which out of viewport (I know because moving cursor extremely to the right show this element coming from the left side). Do you know maybe how to fix it? |
I have the same issue. |
I also have this issue. Portal only solves the swipeable views issue on desktop.. |
Using portals seems to not work with touch input at all. This can be seen on the official portal example. You can activate the draggable object but it does not respond to movement after that. |
This should be fixed in |
Did anyone had a chance to make it work? docs with patterns on portal are gone. Not sure where should I go now with this :/ I am trying version 13.0 but still to no success with EDIT: So actually it works when using cloning API: https://github.com/atlassian/react-beautiful-dnd/blob/master/docs/guides/reparenting.md EDIT 2: For the users of |
@ivellios thanks for the reparenting solution, it works. I'm using If I only toggle the disabled prop of |
Bug or feature request?
Bug
Expected behavior
Drag and drop behaves normally on a touch device (or chrome responsive view)
Actual behavior
Drag does not start or the page scrolls while the draggable stays in a fixed position and does not drop when the finger is lifted.
Steps to reproduce
Use chrome dev console to turn on responsive mode. Go to this code sandbox and try to drag the draggable. https://codesandbox.io/embed/ryp0mkmkzq?codemirror=1
It works fine in desktop (non responsive) mode.
Browser version
Chrome Windows 10 65.0.3325.181
Some interaction between react-swipeable-views and react-beautiful-dnd is breaking DnD only on touch devices. I am using the portal solution here because (as in my reproduction) my app uses react-custom-scrollbars which uses transforms and breaks the normal fixed position behavior.
I am not sure which library is the issue or how to debug, but the reproduction above illustrates the issue nicely.
The text was updated successfully, but these errors were encountered: