Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for empty modification. #17

Open
romaninsh opened this issue Oct 3, 2016 · 1 comment
Open

Add test for empty modification. #17

romaninsh opened this issue Oct 3, 2016 · 1 comment
Assignees
Labels

Comments

@romaninsh
Copy link
Member

romaninsh commented Oct 3, 2016

No description provided.

@romaninsh romaninsh added the S label Oct 3, 2016
@DarkSide666
Copy link
Member

DarkSide666 commented Jan 11, 2019

Empty audit records are generated because they are pushed in beforeSave hook,
but if there was no actual changes in data model, then afterSave hook
is never called, so we can't delete them automatically :(

AND worst thing about this is that we can't add this condition (below)
because then in audit push() save() we can't reload record and all audit
system goes down :(

SO currently we will have these empty audit records and no way to get rid of them.

            $a->addCondition([
                ['descr', 'not', null],
                ['request_diff', 'not', null],
                ['reactive_diff', 'not', null],
            ]);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants