Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add server variables and channel parameters validation #91

Merged
merged 13 commits into from
Jul 2, 2020
Merged

feat: add server variables and channel parameters validation #91

merged 13 commits into from
Jul 2, 2020

Conversation

derberg
Copy link
Member

@derberg derberg commented Jun 19, 2020

Description

  • Add validation for server.url if it has variables that are not described in the variable object
  • Add validation for channel name if it has parameters that are not described in the parameter object

Related issue(s)
Resolves #24

@derberg derberg requested a review from fmvilas June 22, 2020 22:56
package.json Show resolved Hide resolved
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Hope they help!

lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and comments.

lib/customValidators.js Outdated Show resolved Hide resolved
lib/customValidators.js Outdated Show resolved Hide resolved
lib/customValidators.js Outdated Show resolved Hide resolved
lib/customValidators.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
fmvilas
fmvilas previously approved these changes Jul 1, 2020
fmvilas
fmvilas previously approved these changes Jul 1, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg merged commit a65d776 into asyncapi:master Jul 2, 2020
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derberg derberg deleted the varandparamvalidation branch July 2, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIssing validation of channel parameters
3 participants