fix: doc.allSchemas() skips now duplicates #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
smoya
commented
Nov 14, 2023
| import type { SchemasInterface } from '../schemas'; | ||
| import type { OperationInterface } from '../operation'; | ||
| import type { ChannelInterface } from '../channel'; | ||
| import type { ServerInterface } from '../server'; |
There was a problem hiding this comment.
Just reordering and tiding up imports
smoya
commented
Nov 14, 2023
| @@ -12,3 +16,24 @@ export type InferModelMetadata<T> = T extends BaseModel<infer _, infer M> ? M : | |||
| export function createModel<T extends BaseModel>(Model: Constructor<T>, value: InferModelData<T>, meta: Omit<ModelMetadata, 'asyncapi'> & { asyncapi?: DetailedAsyncAPI } & InferModelMetadata<T>, parent?: BaseModel): T { | |||
| return new Model(value, { ...meta, asyncapi: meta.asyncapi || parent?.meta().asyncapi }); | |||
| } | |||
|
|
|||
| export function schemasFromDocument<T extends SchemasInterface>(document: AsyncAPIDocumentInterface, SchemasModel: Constructor<T>, includeComponents: boolean): T { | |||
There was a problem hiding this comment.
Since the logic is exactly the same for both v2 and v3 models, I moved this to this common file.
smoya
commented
Nov 14, 2023
| @@ -213,6 +213,13 @@ describe('AsyncAPIDocument model', function() { | |||
| const d = new AsyncAPIDocument(doc); | |||
| expect(d.allSchemas()).toBeInstanceOf(Schemas); | |||
| }); | |||
| it('should return a collection of schemas (with schemas from components) without duplicates', function() { | |||
| const sharedMessage = { payload: {} }; | |||
There was a problem hiding this comment.
Remember, we compare by "reference" and not by value.
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
|
🎉 This PR is included in version 3.0.0-next-major-spec.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #896
Related issue(s)
#896