Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: schema parsing for v3 #864

Merged
merged 6 commits into from
Oct 9, 2023
Merged

fix: schema parsing for v3 #864

merged 6 commits into from
Oct 9, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Oct 3, 2023 •
edited
Loading

Description
This PR fixes a few things:

  • Fixes schemas are not parsed when having different schema formats
  • Fixes v3 message trait with headers was using incorrect types as they can now be multiformat schemas.

Related issue(s)
Fixes #859

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni requested a review from smoya October 6, 2023 15:09
smoya
smoya approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!🙌

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit a3a4194 into asyncapi:next-major-spec Oct 9, 2023
14 checks passed
@jonaslagoni jonaslagoni deleted the fix_schema_parsing_v2 branch October 9, 2023 08:39
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonaslagoni @asyncapi-bot @smoya