fix: resolve type mismatch in allServers and allChannels #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhudaDad414
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni,
smoya and
asyncapi-bot-eve
as code owners
|
Nice catch @KhudaDad414! Would you mind adding a test covering those cases? 🙏 Also minor thing, please fix the typo in the PR title. |
KhudaDad414
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
@smoya Also added some tests for v3 of the same methods. |
smoya
reviewed
Aug 31, 2023
Comment on lines
+125
to
+128
| const operations: OperationInterface[] = this.operations().all(); | ||
| this.components().operations().forEach(operation => | ||
| !operations.some(o => o.json() === operation.json()) && operations.push(operation) | ||
| ); |
smoya
reviewed
Aug 31, 2023
| this.allOperations().forEach(operation => operation.messages().forEach(message => ( | ||
| !messages.some(m => m.json() === message.json()) && messages.push(message) | ||
| ))); | ||
| const messages: MessageInterface[] = this.messages().all(); |
smoya
approved these changes
Aug 31, 2023
|
/rtm |
|
🎉 This PR is included in version 3.0.0-next-major-spec.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #853