Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for missing 'deprecated' attribute #79

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

jamescrowley
Copy link
Contributor

@jamescrowley jamescrowley commented Apr 28, 2020

Description

Add support for missing 'deprecated' attribute in AsyncAPI schemas. I'm still not 100% clear what ends up in the parser, and what is left for the JSON schema itself, but there doesn't seem to be any way to 'look through' the Schema object to reach these?

Related issue(s)

Fixes #78

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. I realize now that we're also missing the discriminator attribute. I just created an issue here.

Thanks!

@fmvilas fmvilas merged commit bd96a2a into asyncapi:master Apr 28, 2020
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.18.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecated attribute not supported
3 participants