Fix: additional items and properties are never discovered and tests failing on windows #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonaslagoni
commented
Apr 23, 2020
•
jonaslagoni
commented
- fixes Map/Dictionary Parsing Failing #71
- Solves a problems with additional items are never checked by the recursive schema function.
- Solved tests failing on windows but not on linux.
and fixes a problem with "additionalItems" are never checked
… even if not on linux. Fixed a problem with the parse_test where offsets are not caluclated.
jonaslagoni
requested review from
fmvilas and
derberg
and removed request for
fmvilas
jonaslagoni
changed the title
|
@ryanskinner do you have time to check if this fixes your overall use-case? |
fmvilas
requested changes
Apr 27, 2020
Co-Authored-By: Fran Méndez <[email protected]>
Co-Authored-By: Fran Méndez <[email protected]>
fmvilas
approved these changes
Apr 27, 2020
|
🎉 This PR is included in version 0.18.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.