fix: dereference is failing with url references

[fmvilas]

This is a temporary fix meanwhile the folks at @APIDevTools merge this pull request or another one solving the same problem.

The problem is that when a $ref like https://myserver.com/mySchema.json fails to download (either because it doesn't exist or another kind of errors), the information we get about the error is not that much. We get a message, a status, and some other information but we don't know which $ref provoked this error, i.e., the https://myserver.com/mySchema.json.

We need to know which $ref provoked the error so that we're able to locate it in the document and give a nice hint to the user on how and where the error is.

Update

I closed my PR because it doesn't make sense anymore. However, I can't still stop pointing to my fork because of this: APIDevTools/json-schema-ref-parser#164.

[fmvilas]

This is pointing to my fork until the other PR gets merged.

[derberg]

just few questions:

• you take dependency from your fork but from master, why not add-more-info-about-errors that you used for the PR to apidevtools (btw you have conflicts there)
• when I look on the yaml with example of ref broken by new line, I think it shoudl be added to tck. I'm not saying you should do it now. I'm thinking now that tck should actually become a library so you can have it in your devDependencies and inject into the tests, for example parser tests. What do you think?

I approve, well done,
I approve cause I assume you want to ref master of the fork in dependencies and you will care to always synchronize fork-branch with fork-master (although making sure your fork is up to date with upstream will be difficult)

[jonaslagoni]

Already notified @fmvilas but the tests does not succeed in Windows. Just wanted to make sure it won't get merged untill fixed 😄

[fmvilas]

@derberg Good call. I pointed to the branch on the fork. And agree about the TCK. It would be awesome to have it running on Github Actions too.

@jonaslagoni Tests are now fixed and taking into account EOL's format (/r/n or /n).

---

I also closed my PR because the Stoplight folks added a new feature to this library and, on the way, solved the problem I was fixing (perfect!). However, I'm still pointing to my fork because there's a bug on their implementation: APIDevTools/json-schema-ref-parser#164. Therefore, I'll keep using my fork until it gets fixed and released.

[derberg]

lgtm

[asyncapi-bot]

🎉 This PR is included in version 0.18.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀