Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove dist/bundle.js from gitignore to get it pushed to npm #64

Merged
merged 2 commits into from
Apr 14, 2020
Merged

feat: remove dist/bundle.js from gitignore to get it pushed to npm #64

merged 2 commits into from
Apr 14, 2020

Conversation

derberg
Copy link
Member

@derberg derberg commented Apr 14, 2020

Description

  • remove .keep as bundle.js will alwasy be in dist dir
  • remove dist from gitignore as now it is not published to npm. Now with each release bundle.js will be pushed to repo with PR that bumps package.json

fmvilas
fmvilas approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try like this for some time but I'm afraid that we'll get a lot of merging conflicts with the bundle.js file. Not that it's a huge problem, we can always generate it ourselves locally but it's a pain.

@derberg derberg merged commit e891f7a into asyncapi:master Apr 14, 2020
@derberg derberg deleted the fix-bundle branch April 14, 2020 18:06
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derberg @asyncapi-bot @fmvilas