Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add configuration for automated releases #53

Merged
merged 5 commits into from
Mar 23, 2020
Merged

feat: add configuration for automated releases #53

merged 5 commits into from
Mar 23, 2020

Conversation

derberg
Copy link
Member

@derberg derberg commented Mar 19, 2020 •
edited
Loading

Same as asyncapi/generator#242 except of:

  • I removed dist dir and added to ignore as since we will add it to release artifact, I do not think we should commit it to repository
  • no docker release
  • added step to run npm test
  • avoided mistakes done with generator - package marked as public, readme updated, travis removed
  • generating bundle.js and attaching to the GitHub release as an artifact

See also #52

@derberg derberg marked this pull request as ready for review March 20, 2020 09:24
@fmvilas
Copy link
Member

fmvilas commented Mar 20, 2020

generating bundle.js and attaching to the GitHub release as an artifact

It's definitely more elegant 👍

fmvilas
fmvilas previously approved these changes Mar 20, 2020
View reviewed changes
@derberg derberg merged commit 617bd02 into asyncapi:master Mar 23, 2020
@derberg derberg deleted the release-automation branch March 23, 2020 15:47
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derberg @fmvilas @asyncapi-bot