Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allSchemas to return all schemas #41

Merged
merged 5 commits into from
Apr 9, 2020
Merged

fix: allSchemas to return all schemas #41

merged 5 commits into from
Apr 9, 2020

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Mar 5, 2020 •
edited
Loading

Solving #39

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Mar 6, 2020 •
edited
Loading

The implementation is done, however the PR is blocked by #42.

@jonaslagoni
Copy link
Member Author

After implementing #43 I realized that we might get quite a few uid duplicates, how can we handle that in regards to the allSchemas function? 🤔

@fmvilas fmvilas added this to the Make JS parser stable milestone Mar 13, 2020
@hesyar
Copy link

hesyar commented Apr 3, 2020

We have the same issue in our company, when will this PR be merged?

@jonaslagoni
Copy link
Member Author

@hesyar as soon as im done with #43 😄

@jonaslagoni jonaslagoni mentioned this pull request Apr 3, 2020
Merged
@jonaslagoni jonaslagoni marked this pull request as ready for review April 9, 2020 16:43
@jonaslagoni jonaslagoni requested review from derberg and fmvilas and removed request for derberg April 9, 2020 16:44
fmvilas
fmvilas approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@derberg derberg changed the title All schemas should be returned feat: allSchemas to return all schemas Apr 9, 2020
@derberg derberg changed the title feat: allSchemas to return all schemas fix: allSchemas to return all schemas Apr 9, 2020
@derberg derberg merged commit c715954 into asyncapi:master Apr 9, 2020
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@derberg derberg Awaiting requested review from derberg

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
Make JS parser stable
Development

Successfully merging this pull request may close these issues.
5 participants
@jonaslagoni @hesyar @asyncapi-bot @fmvilas @derberg