Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply correctly traits to channels #108

Merged
merged 2 commits into from
Jul 7, 2020
Merged

fix: apply correctly traits to channels #108

merged 2 commits into from
Jul 7, 2020

Conversation

magicmatatjahu
Copy link
Member

Description

  • Apply correctly traits to channels, also for oneOf messages.

Related issue(s)
Resolves #96

@magicmatatjahu magicmatatjahu added the bug Something isn't working label Jul 6, 2020
@magicmatatjahu magicmatatjahu mentioned this pull request Jul 6, 2020
Closed
jonaslagoni
jonaslagoni requested changes Jul 6, 2020
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, left some comments that needs to be addressed 😄

test/parse_test.js Show resolved Hide resolved
lib/parser.js Outdated Show resolved Hide resolved
lib/parser.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jonaslagoni
jonaslagoni approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@derberg
Copy link
Member

derberg commented Jul 7, 2020

lgtm
thanks @magicmatatjahu @jonaslagoni

@derberg derberg merged commit 769e4f8 into asyncapi:master Jul 7, 2020
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@magicmatatjahu magicmatatjahu deleted the 96-invalid-traits branch July 7, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message traits are not applied when using oneOf on channels
4 participants
@magicmatatjahu @derberg @asyncapi-bot @jonaslagoni