Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validation checking if operationIds are duplicated #105

Merged
merged 7 commits into from
Jul 9, 2020
Merged

feat: validation checking if operationIds are duplicated #105

merged 7 commits into from
Jul 9, 2020

Conversation

derberg
Copy link
Member

@derberg derberg commented Jul 3, 2020 •
edited
Loading

Description

  • validation checking if operationIds are duplicated

Related issue(s)
Resolves #10

@derberg derberg requested a review from fmvilas July 6, 2020 09:19
derberg
derberg commented Jul 6, 2020
View reviewed changes
lib/customValidators.js Outdated Show resolved Hide resolved
derberg
derberg commented Jul 6, 2020
View reviewed changes
lib/customValidators.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

fmvilas
fmvilas approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 👏

@derberg derberg merged commit 3d29302 into asyncapi:master Jul 9, 2020
@derberg derberg deleted the operationid branch July 9, 2020 12:57
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List down manual validations
3 participants
@derberg @asyncapi-bot @fmvilas