-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser do not validate and throw error when parameters
are provided but address is null
#875
Comments
We need to adapt the spectral rules to solve this issue. Here is how:
This issue is marked as good first issue, but it's a medium difficulty! Remember to target the next-major-spec branch. |
/gfi typescript |
Note that the linked rule only applies for channels with parameters in their address. Otherwise, it just skips it. See the following code that executes for the channel address:
We need to additionally make it fail in case there are parameters defined for such a channel but they are not added into the address. This is the usecase @derberg shared.
This is not anymore a requirement since all v3-related stuff has been merged now to cc @Min2who |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Like in the subject.
Document:
it should not be a valid document and I should get an error saying that I have parameters but there are no parameters in the address
The text was updated successfully, but these errors were encountered: