Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up conductor chain ID tests #1602

Open
ethanoroshiba opened this issue Sep 30, 2024 · 1 comment · May be fixed by #1765
Open

chore: clean up conductor chain ID tests #1602

ethanoroshiba opened this issue Sep 30, 2024 · 1 comment · May be fixed by #1765
Labels
conductor pertaining to the astria-conductor crate ignore-stale Override for issues or PRs which should not be removed if stale. testing

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Sep 30, 2024 •
edited by sync-by-unito bot
Loading

As indicated in this comment the conductor chain ID check tests are quite messy due to the manual mounting and testing for the correct exit error. We should find a way to clean this up.

astria/crates/astria-conductor/tests/blackbox/firm_only.rs

Lines 417 to 419 in 8510b64

// We have to create our own test conductor and perform mounts manually because `TestConductor`
// implements the `Drop` trait, which disallows us from taking ownership of its tasks and
// awaiting their completion.

astria/crates/astria-conductor/tests/blackbox/soft_only.rs

Lines 371 to 373 in 8510b64

// We have to create our own test conductor and perform mounts manually because `TestConductor`
// implements the `Drop` trait, which disallows us from taking ownership of its tasks and
// awaiting their completion.

┆Issue Number: ENG-892
@ethanoroshiba ethanoroshiba added conductor pertaining to the astria-conductor crate testing labels Sep 30, 2024
@ethanoroshiba ethanoroshiba linked a pull request Oct 29, 2024 that will close this issue
Open
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@ethanoroshiba ethanoroshiba added ignore-stale Override for issues or PRs which should not be removed if stale. and removed stale labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conductor pertaining to the astria-conductor crate ignore-stale Override for issues or PRs which should not be removed if stale. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(conductor): clean up chain id tests astriaorg/astria
2 participants
@joroshiba @ethanoroshiba