-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate potential remaining items for Chai v4 support #86
Comments
Is there any update on version 2? |
Hi @probedb! I stiiiill haven't finished this, I'm sorry. I'm almost there, there are a couple things left I want to look at before publishing this. Sorry about this! In the meantime, I have just published Thanks! |
@astorije no problem, I'll give it a try tomorrow when I have chance to test it :) |
@probedb, any luck? |
Hey @probedb, I have just released v2.0.0-rc.2 which hopefully is the last step before full Chai v4 support (finally!). Mind giving it a shot and letting me know if it works as expected for you? |
Sorry @astorije ended up busy! I've updated to 2.0.0-rc.2 and chai 4.1.2 and the only issues I have are: when doing:
I get: AssertionError: expected [Error: something went wrong] to deeply equal [Error: something went wrong]
+ expected - actual But I've had this before with error objects, there's 13 errors like this after the update. |
I suspect this is unrelated to |
@astorije yep I'd agree, I believe it's due to the way the object is created for comparison and something has changed in Chai. |
A long, long time ago, I listed a few things to look at to be ready for Chai v4 here: #69 (comment)
Need to wrap these.
The text was updated successfully, but these errors were encountered: