Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ts_proto_library copy sources does not support having more than one proto_library in a BUILD file #601

Open
mrmeku opened this issue Apr 30, 2024 · 0 comments
Labels
bug Something isn't working untriaged Requires traige

Comments

@mrmeku
Copy link
Contributor

mrmeku commented Apr 30, 2024

What happened?

Right now ts_proto_library uses proto_srcs = native.glob(["**/*.proto"]) to detect what generated files it should expect to copy. This is a convenient but erroneous assumption. If a particular build file has two protos a.proto and b.proto but only a.proto was used to generate a ts_proto_library this assumption breaks and you are forced to disable source copying or merge the proto_libraries together

Version

Development (host) and target OS/architectures: all

Output of bazel --version: all

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 987b6ac

Language(s) and/or frameworks involved: starlark

How to reproduce

No response

Any other information?

No response

@mrmeku mrmeku added the bug Something isn't working label Apr 30, 2024
@github-actions github-actions bot added the untriaged Requires traige label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged Requires traige
Projects
None yet
Development

No branches or pull requests

1 participant