Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to generalize context propagation pattern #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashamukov
Copy link
Owner

@ashamukov ashamukov commented Oct 25, 2019

See introduction comment in the issue: ...

Implementation details:

  • common part is extracted from org.springframework.security.concurrent package to org.springframework.util.concurrent (to be easy-movable to spring-core)
  • security specific part is kept in org.springframework.security.concurrent
  • all public classes in org.springframework.security.concurrent are kept existing, for backward compatibility reasons (e.g. DelegatingSecurityContextRunnable is not actually needed any more, and can be removed in favor of DelegatingContextRunnable, but is kept)
  • SecurityContextOps implementation of ContextOps is used to incapsulate and provide security-specific behavior
  • Interfaces ContextOps and SecurityContextHolderStrategy are pretty similar, but probably should be kept both (one for backward-compatibility, another - to be moved in spring-core)

Haven't done yet:

  • probably it is also worth to generalize:
    • DelegatingSecurityContextAsyncTaskExecutor
    • DelegatingSecurityContextTaskExecutor
      (right now they extend specific base classes)
  • doc polishing & test fixes

@ashamukov ashamukov changed the title Attempt to generalize context delegation for concurrent package Attempt to generalize context propagation pattern Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant