Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reactor modules to be entered directy as manual action implemenations. #1514

Open
jimsynz opened this issue Oct 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jimsynz
Copy link
Contributor

jimsynz commented Oct 13, 2024

We already have this for generic actions, however in some cases one may want to simulate a CRUD action using a Reactor. It's easy enough to do by making a custom action implementation, however we can same folks some hassle by allowing a reactor module to be specified as the action definition and run it using a built-in action implementation.

@jimsynz jimsynz added the enhancement New feature or request label Oct 13, 2024
@zachdaniel
Copy link
Contributor

My only hesitation here is that generic action modules can have multiple callbacks, which could make it a hassle to switch to a non-reactor solution if you have to implement one of the other callbacks. We may run into this same limitation if we ever want to support batching generic actions too, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants