-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__has_feature may not be accurate #168
Comments
@chuim, what do you think the best solution is here? |
Thanks for looping me in. I have no experience on cross compiler support so I have no suggestion to propose. I can try to research a solution once I'm back from the holidays, early next year. |
Cool, thanks! |
GCC defines the Also, that snippet of code from Qt seems odd as it decides to override that macro with an always-false implementation what might mislead decisions from other macros in the code. |
Hi @chuim, Thanks for investigating the issue! Regarding the GCC setup, if you use the |
For example, Qt will define this macro even if it was not defined.
And looks like
gcc version 9.3.0 (Gentoo 9.3.0-r1 p3)
does not have__has_feature
pre-defined.So if immer headers are included after Qt headers, immer will deem that there is no exception supported, even if I use
-fexceptions
.I guess we should at least allow user to always use exceptions (which is important for things like
lager::lenses::at
because it uses exception to fill in theoptional
).The text was updated successfully, but these errors were encountered: