Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Integration test for the protoc-gen bin #95

Open
arthurnn opened this issue Jan 6, 2023 · 0 comments
Open

Task: Integration test for the protoc-gen bin #95

arthurnn opened this issue Jan 6, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@arthurnn
Copy link
Owner

arthurnn commented Jan 6, 2023

Do we test the protocol-gen-twirp_ruby ?

  1. I see the go bin has a main_test.go file, but I don't see we call it during our action CI build
    Note: cd protoc-gen-twirp_ruby && go test ./... will execute the test
  2. We could have a integration test, where from a .proto file we generate the stubs, and asserts against that, to prevent major breaking changes.
  3. Idea: bring some of the example app as part of our test suite.

1 is a easy win, 2 and 3 are more like ideas, but the overall goal here is to have tests that trigger the protoc ruby bin.
@arthurnn arthurnn added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arthurnn