Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armbian-bsp-cli: fix 10-wifi-disable-powermanagement.rules #7130

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

armbian-bsp-cli: fix 10-wifi-disable-powermanagement.rules #7130

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0308243
armbian-bsp-cli: fix 10-wifi-disable-powermanagement.rules
alexl83 Aug 23, 2024
d45f5f0
Fix rule syntax
alexl83 Aug 24, 2024
7250699
Merge branch 'main' into fix_wifi_powermanagenet_rules
alexl83 Aug 27, 2024
6e082d9
Merge branch 'main' into fix_wifi_powermanagenet_rules
alexl83 Aug 27, 2024
2de7804
Merge branch 'main' into fix_wifi_powermanagenet_rules
alexl83 Aug 29, 2024
c91909c
Merge branch 'main' into fix_wifi_powermanagenet_rules
alexl83 Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/bsp/common/etc/udev/rules.d/10-wifi-disable-powermanagement.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
KERNEL=="wlan*", ACTION=="add", RUN+="/sbin/iw dev %k set power_save off"
SUBSYSTEM=="net", ACTION!="remove", ENV{DEVTYPE}=="wlan", RUN+="/usr/sbin/iw dev $name set power_save off"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is path actually needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wouldn't find iw without path - probably something related to udev sandboxing or some restriction of sorts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. got it. Other problem could be that different userland have different location - check for jammy, noble, bookworm, trixie

Copy link
Contributor Author

@alexl83 alexl83 Aug 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. got it. Other problem could be that different userland have different location - check for jammy, noble, bookworm, trixie

You're right Pal, bookworm and Jammy have /sbin/iw but rule without absolute path won't work
need to find a way..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, classic :)