-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Pitch Accents #157
Comments
You will need this CSS under your template.
I recommend making a new field for it beside what your current template uses, and using those two fields, one for your current implementation and another for my format. In the future, I will probably make an enhancement that sets the pitch accent to be of other more common formats rather than my own format that I botched up together. For your other questions,
Let me know if you still have any trouble. I am currently at the early development stages of something that I am carefully working on this time while taking much better care of myself (and for the codebase for that matter), so I see myself as in hiatus and not actively looking to make new releases for the current major version at this time, unfortunately. |
Awesome, thanks! Got that all to work. I was expecting the ImmersionKit user enhancement to be under "sentence" instead of "term," but that's all set up now. Appreciate all your hard work. I'd love in the future to be able to do graphs like these as I think they're a little nicer, but not essential at all. Finally, is it possible to enable some of these frequency dictionaries in JidouJisho? I have them added, but haven't seen them pop up. I like to have some way of checking that a word I'm considering adding isn't too uncommon or archaic, and sometimes get a note about the JLPT level, but these would be awesome to add to the dictionary. Thanks again! |
Hey, @ian-battaglia. Missed an edge case which caused issues importing those dictionaries you've linked. I've included the fix for that in a new build below. This build includes a work in progress 2.4.0 (only supporting Japanese at the moment) that includes an overhaul of the dictionary system and should be much, much faster than the current system, supports wildcard searching (? or ? for one character, * or ※ (こめ) for zero to any characters) but will require a fresh installation. You can get the build here. As for the graphs, I can probably support them as an enhancement you can enable -- Would you be willing to share the internal structure/how the graphs in your current template work? |
Changes for the frequency dictionaries have been included in the 2.4 preview. |
This is great, thanks so much! Going to download and get this running now. As for the pitch accent graphs, I think they're just natively included as part of the Kanjium Pitch Accent Dictionary. In Yomichan, if you hit the "advanced" settings toggle, there's a few different options for pitch accent graph under the "appearance" tab. Not sure how easy or hard copying this implementation over would be, but it'd definitely be nice to have. Thanks for all your hard work! |
It would help me if you could share how your CSS and card format looks -- I can probably guess backwards based on the output how to implement it. I'll probably implement it as an enhancement which modifies how the pitch accent text is generated in the Creator. |
For picking out which dictionary definitions get exported, I'm trying to figure out a good user experience for the feature at the moment. My current idea is to make an auto enhancement for the expanded and collapsed meaning fields that changes the behaviour to "currently expanded" and "currently collapsed" upon opening the Creator or so. I've had some users think that that should be the default behaviour of the field too, I'd like to implement a way to do it without having the user manually adjust things in the Creator itself, and to allow them to continue to use the app organically as they already would. |
Sure thing. These graphs actually just get dropped directly into the field as it comes in from Yomichan, really not sure how they're rendering it. Here are some screenshots of a sample card I made with Yomichan that has that graph format. Re: selective definition export, that sounds great. For example, my set up is primarily the 明鏡国語辞典 and 大辞林 dictionary, plus JMdict and KireiCake for slang or whatever. But when I actually make a card, I usually just want the actual dictionary definition from 明鏡国語辞典 (not the part of speech or whatever) and sometimes the first definition or so from JMDict. Right now, I've been just exporting the cards as default, and just going through and editing the definition field in Anki before I review for the day. |
Hi @ian-battaglia. Just reaching out to let you know selective definition export is available in 2.5. I'm not closing this issue yet as I still want to make the pitch accent diagrams template and CSS agnostic, and I'd like to make some modifications to the default template while I'm at it. |
Awesome, thanks! |
Closing now that 2.7 has template-agnostic pitch accent diagrams that use SVG. |
I put this under "Discussions" a while back since I didn't think it was really an issue, but maybe this is a better place for it.
I just started using jidoujisho, version 2.3.7, and it's really impressive! I'm able to mirror my mining setup on mobile with it. Only issue is that I haven't been able to get the pitch accent graph working.
I'm using a card template that's a slightly older version of this one, which adds a pitch accent graph from Kanjium into a field called "Graph." I was looking at the update from when pitch accents were added, 0.17, which is supposed to have a link to the template on how to add the CSS to your cards, but that link is dead. How should I get this to work?
I have two other questions as well, not sure if these should be spun off into their own "issues."
Thanks!
The text was updated successfully, but these errors were encountered: