Exclude more logic when compiling with librashader=false #1541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current configuration options wrt librashader
Building currently supports
librashader=false
(default true) to disable librashader supportCurrently, it merely means not copying the library binary to the output (for the platforms that do)
This PR
This PR defines the
NO_LIBRASHADER
cpp macro underlibrashader=false
, causing shader support in ares to be more thoroughly disabled, some code is #if'd out and the Shader menu in the UI is disabled.Also featuring tiny bits of cleanup in related parts of the Makefile and code.
Comments are welcome. I'm far from a C++ expert.
Motivation
This was prompted to me by ares complaining in the console like
I personally don't use shaders so I tried compiling with
librashader=false
, which didn't get rid of that warning, so here we are. I could also just #if out the warning but it didn't feel as proper.