getPermalinkBaseUrl() must not add the scheme

[tchapi]

The APP_URL configuration setting in Laravel is supposed to include the scheme.

For instance in the .env.example file :

APP_URL=https://mydomain.com

See https://github.com/laravel/laravel/blob/master/.env.example for instance and https://github.com/laravel/laravel/blob/master/config/app.php#L55 too.

So in the Twill module controller, getPermalinkBaseUrl() must not add the scheme in front of the APP_URL config of Laravel :

https://github.com/area17/twill/blob/master/src/Http/Controllers/Admin/ModuleController.php#L1388

This breaks the permalink href (with a double scheme, such as http://https://mydomain.com)

The method should be something like :

        return Config::get('app.url') . '/'
            . ($this->moduleHas('translations') ? '{language}/' : '')
            . ($this->moduleHas('revisions') ? '{preview}/' : '')
            . ($this->permalinkBase ?? $this->moduleName)
            . (isset($this->permalinkBase) && empty($this->permalinkBase) ? '' : '/');

[tchapi]

We're now talking about this line https://github.com/area17/twill/blob/master/src/Http/Controllers/Admin/ModuleController.php#L1500

[tchapi]

I guess this is fixed by #651