refactor compositor

[ardera]

No description provided.

[Stefichen5]

I am having issues compiling this (#d8c7b4595454c89a7017c73793ad00490c79dc1f). I get the following error:

.../flutter-pi-d8c7b4595454c89a7017c73793ad00490c79dc1f/src/plugins/gstreamer_video_player/frame.c:518:61: error: ‘i’ undeclared (first use in this function)
  518 |         guint x_tiles = GST_VIDEO_TILE_X_TILES(info->stride[i]);
      |                                                             ^

Looking inside the file, I think I can see the problem:

static bool calculate_plane_size(const GstVideoInfo *info, int plane_index, size_t *plane_size_out) {
    // Taken from: https://github.com/GStreamer/gstreamer/blob/621604aa3e4caa8db27637f63fa55fac2f7721e5/subprojects/gst-plugins-base/gst-libs/gst/video/video-info.c#L1278-L1301

    #if THIS_GSTREAMER_VER >= GSTREAMER_VER(1, 21, 3)
    if (GST_VIDEO_FORMAT_INFO_IS_TILED(info->finfo)) {
        guint x_tiles = GST_VIDEO_TILE_X_TILES(info->stride[i]);
        guint y_tiles = GST_VIDEO_TILE_Y_TILES(info->stride[i]);
        return x_tiles * y_tiles * GST_VIDEO_FORMAT_INFO_TILE_SIZE(info->finfo, i);
    }
    #endif
   //...

Compared to the source:

for (i = 0; i < GST_VIDEO_MAX_PLANES; i++) {
      if (i < GST_VIDEO_INFO_N_PLANES (info)) {
        if (GST_VIDEO_FORMAT_INFO_IS_TILED (info->finfo)) {
          guint x_tiles = GST_VIDEO_TILE_X_TILES (info->stride[i]);
          guint y_tiles = GST_VIDEO_TILE_Y_TILES (info->stride[i]);
          plane_size[i] = x_tiles * y_tiles *
//...

I think the following patch might help (at least it compiles):

-    if (GST_VIDEO_FORMAT_INFO_IS_TILED(info->finfo)) {
-        guint x_tiles = GST_VIDEO_TILE_X_TILES(info->stride[i]);
-        guint y_tiles = GST_VIDEO_TILE_Y_TILES(info->stride[i]);
-        return x_tiles * y_tiles * GST_VIDEO_FORMAT_INFO_TILE_SIZE(info->finfo, i);
+    for (int i = 0; i < GST_VIDEO_MAX_PLANES; i++) {
+        if (GST_VIDEO_FORMAT_INFO_IS_TILED(info->finfo)) {
+            guint x_tiles = GST_VIDEO_TILE_X_TILES(info->stride[i]);
+            guint y_tiles = GST_VIDEO_TILE_Y_TILES(info->stride[i]);
+            *plane_size_out = x_tiles * y_tiles * GST_VIDEO_FORMAT_INFO_TILE_SIZE(info->finfo, i);
+            return true;
+        }

[ardera]

@Stefichen5 Thanks for reporting, actually that's a typo and the fix is to use plane_index instead of i :)
It's fixed in efa730d 9cb0ae4.