Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename validateEmail options to align with detectBot and sensitiveInfo options #1834

Open
Tracked by #928
blaine-arcjet opened this issue Oct 2, 2024 · 1 comment · May be fixed by #2661
Open
Tracked by #928

Rename validateEmail options to align with detectBot and sensitiveInfo options #1834

blaine-arcjet opened this issue Oct 2, 2024 · 1 comment · May be fixed by #2661
Assignees
@e-moran

Comments

@blaine-arcjet
Copy link
Contributor

The validateEmail currently uses block to indicate which email types to deny. We should change this to deny like detectBot and sensitiveInfo now use.

Also, should we add an allow variant here? cc @davidmytton
@blaine-arcjet blaine-arcjet mentioned this issue Oct 2, 2024
Open
19 tasks
@davidmytton
Copy link
Contributor

Yes I think we should match the API of the others, including allow.

@e-moran e-moran linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-moran e-moran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support allow and deny config of validateEmail rule arcjet/arcjet-js
3 participants
@davidmytton @e-moran @blaine-arcjet