Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config insecure when pull policy #2228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tranthang2404
Copy link

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the bug label Aug 14, 2024
@fnerdwq
Copy link

fnerdwq commented Sep 24, 2024

Is there a potential release date for this fix?
Thanks

@Berodin
Copy link

Berodin commented Sep 24, 2024

Highly interested in that as well

@kingspeedy95
Copy link

I am very interested in that as well.

1 similar comment
@andyalamo
Copy link

I am very interested in that as well.

@ravenolf
Copy link

Also interested in this as the helm value policiesBundle.insecure doesn't seem to any difference. This is especially useful when using an internal mirror registry since the only supported way to add custom CA/Certs is via hostpath making it bit limiting

@teimyBr
Copy link

teimyBr commented Oct 25, 2024

also would be very help full for us

@MarcoSchmitz
Copy link

Also interested in that and a release date would be nice to have.

@afdesk afdesk requested review from simar7 and afdesk and removed request for chen-keinan November 26, 2024 09:44
Copy link
Contributor

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for the contribution!

@afdesk
Copy link
Contributor

afdesk commented Nov 26, 2024

@simar7 could you take a look too?

@teimyBr
Copy link

teimyBr commented Nov 26, 2024

Yeah looking forward when this is merged for a new release :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trivy operator flag insecure not working - failed to verify certificate: x509
10 participants