Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable starboard to check for http and https prefixes for server from… #90

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Enable starboard to check for http and https prefixes for server from… #90

merged 1 commit into from
Jul 13, 2020

Conversation

krisctl
Copy link
Contributor

@krisctl krisctl commented Jul 11, 2020

… dockerconfig secret

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   11.51%   11.51%           
=======================================
  Files          27       27           
  Lines        1277     1277           
=======================================
  Hits          147      147           
  Misses       1123     1123           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44210b1...6affd4e. Read the comment docs.

@danielpacak danielpacak self-requested a review July 13, 2020 21:12
danielpacak
danielpacak approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thank you @Krishan-Sharma for this improvement!

@danielpacak danielpacak merged commit 2e28ff8 into aquasecurity:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpacak danielpacak danielpacak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krisctl @danielpacak