Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polaris to 1.1.0 #86

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Update polaris to 1.1.0 #86

merged 4 commits into from
Jul 10, 2020

Conversation

danielsagi
Copy link
Contributor

Up until now we used an old tagged version of Polaris.
This PR updates the polaris release tag to 1.1.0

Changes made to support the new version:

  • Now explicitly specifying the audit config file in the command line.
  • Changed the audit config file to an updated default version. (some old values were no longer supported)

related #33

@danielsagi danielsagi added the 🔦 plugin/polaris This issue is somehow related to Fairwinds Polaris label Jul 10, 2020
@danielsagi danielsagi requested a review from danielpacak July 10, 2020 13:00
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #86 into master will increase coverage by 2.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage    9.10%   11.51%   +2.40%     
==========================================
  Files          26       27       +1     
  Lines        1153     1277     +124     
==========================================
+ Hits          105      147      +42     
- Misses       1043     1123      +80     
- Partials        5        7       +2     
Impacted Files Coverage Δ
pkg/find/vulnerabilities/trivy/scanner.go 0.00% <0.00%> (ø)
pkg/kube/cr_manager.go 0.00% <ø> (ø)
pkg/polaris/scanner.go 0.00% <0.00%> (ø)
pkg/kubebench/scanner.go 0.00% <0.00%> (ø)
pkg/find/vulnerabilities/crd/writer.go 42.10% <0.00%> (ø)
pkg/docker/config.go 90.00% <0.00%> (+1.11%) ⬆️
pkg/find/vulnerabilities/trivy/converter.go 83.33% <0.00%> (+4.87%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 980af79...9406b6c. Read the comment docs.

Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielpacak danielpacak merged commit 44210b1 into master Jul 10, 2020
@danielpacak danielpacak deleted the update-polaris branch December 17, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔦 plugin/polaris This issue is somehow related to Fairwinds Polaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants