Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for empty server lines in docker config #77

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

krisctl
Copy link
Contributor

@krisctl krisctl commented Jul 3, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #77 into master will increase coverage by 0.14%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #77      +/-   ##
=========================================
+ Coverage    9.10%   9.25%   +0.14%     
=========================================
  Files          26      26              
  Lines        1153    1156       +3     
=========================================
+ Hits          105     107       +2     
- Misses       1043    1044       +1     
  Partials        5       5              
Impacted Files Coverage Δ
pkg/find/vulnerabilities/trivy/scanner.go 0.00% <0.00%> (ø)
pkg/docker/config.go 90.00% <100.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 980af79...dd454a4. Read the comment docs.

@danielpacak danielpacak self-requested a review July 3, 2020 17:38
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix @Krishan-Sharma !

@danielpacak danielpacak merged commit f87b354 into aquasecurity:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants