Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: script to use krew-release-bot #72

Merged
merged 3 commits into from
Jun 25, 2020

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Jun 24, 2020

About Issue #58 was added the file .krew.yaml to integrate with krew-release-bot

Testing

docker run --mount type=bind,source=$PWD/.krew.yaml,target=/tmp/krew.yaml rajatjindal/krew-release-bot:v0.0.38 \
  krew-release-bot template --tag v0.2.2 --template-file /tmp/krew.yaml

image

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #72   +/-   ##
======================================
  Coverage    9.10%   9.10%           
======================================
  Files          26      26           
  Lines        1153    1153           
======================================
  Hits          105     105           
  Misses       1043    1043           
  Partials        5       5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898d422...fbfad4a. Read the comment docs.

@danielpacak
Copy link
Contributor

danielpacak commented Jun 24, 2020

@krol3 @evalsocket I think we're missing one step to actually send an event to the bot whenever a new release is performed. See for example https://github.com/ahmetb/kubectl-tree/blob/master/.github/workflows/release.yml#L23

@krol3
Copy link
Contributor Author

krol3 commented Jun 25, 2020

The workflow syntax for Github actions works in .github, I didn't notice :( . I updated the PR

@danielpacak
Copy link
Contributor

I pushed one more commit to make the krew manifest template as close to the existing one as possible https://github.com/kubernetes-sigs/krew-index/blob/master/plugins/starboard.yaml

Otherwise it would not get merged automatically.

@danielpacak danielpacak merged commit 6761c67 into aquasecurity:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants