Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Allow plugins to provide the default config #611

Merged
merged 1 commit into from
May 31, 2021

Conversation

danielpacak
Copy link
Contributor

Signed-off-by: Daniel Pacak [email protected]

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #611 (a7f5b9e) into main (ca3211b) will decrease coverage by 0.42%.
The diff coverage is 46.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   69.03%   68.61%   -0.43%     
==========================================
  Files          58       58              
  Lines        4382     4387       +5     
==========================================
- Hits         3025     3010      -15     
- Misses       1015     1032      +17     
- Partials      342      345       +3     
Impacted Files Coverage Δ
pkg/starboard/plugin.go 51.85% <0.00%> (-16.45%) ⬇️
pkg/cmd/scan_configauditreports.go 59.18% <33.33%> (-1.69%) ⬇️
pkg/operator/operator.go 63.43% <33.33%> (-0.69%) ⬇️
pkg/plugin/conftest/plugin.go 86.87% <100.00%> (+0.42%) ⬆️
pkg/plugin/polaris/plugin.go 90.14% <100.00%> (+0.43%) ⬆️
pkg/starboard/config.go 70.71% <100.00%> (-6.26%) ⬇️
pkg/operator/controller/configauditreport.go 64.81% <0.00%> (-1.86%) ⬇️
pkg/operator/controller/ciskubebenchreport.go 62.76% <0.00%> (-1.60%) ⬇️
pkg/operator/controller/vulnerabilityreport.go 68.03% <0.00%> (+2.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca3211b...a7f5b9e. Read the comment docs.

@danielpacak danielpacak force-pushed the refactor_plugin_config branch from e70c421 to b3909c1 Compare May 31, 2021 09:51
@danielpacak danielpacak marked this pull request as ready for review May 31, 2021 09:57
@danielpacak danielpacak force-pushed the refactor_plugin_config branch from b3909c1 to a7f5b9e Compare May 31, 2021 10:03
@danielpacak danielpacak merged commit 8f97a54 into main May 31, 2021
@danielpacak danielpacak deleted the refactor_plugin_config branch May 31, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant