Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove config checkers config from generic starboard ConfigMap #603

Merged
merged 1 commit into from
May 26, 2021

Conversation

danielpacak
Copy link
Contributor

Signed-off-by: Daniel Pacak [email protected]

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #603 (b8b8d07) into main (fd93a8c) will increase coverage by 0.22%.
The diff coverage is 65.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   70.95%   71.18%   +0.22%     
==========================================
  Files          57       57              
  Lines        4242     4251       +9     
==========================================
+ Hits         3010     3026      +16     
+ Misses        890      884       -6     
+ Partials      342      341       -1     
Impacted Files Coverage Δ
pkg/starboard/plugin.go 68.29% <0.00%> (-9.49%) ⬇️
pkg/plugin/conftest/plugin.go 86.45% <66.66%> (-1.05%) ⬇️
pkg/plugin/polaris/plugin.go 89.70% <75.00%> (-1.28%) ⬇️
pkg/configauditreport/scanner.go 70.76% <100.00%> (ø)
pkg/operator/controller/configauditreport.go 67.59% <100.00%> (+2.77%) ⬆️
pkg/plugin/factory.go 80.48% <100.00%> (ø)
pkg/starboard/config.go 78.49% <100.00%> (+0.83%) ⬆️
pkg/operator/controller/ciskubebenchreport.go 63.29% <0.00%> (+0.53%) ⬆️
pkg/operator/controller/vulnerabilityreport.go 68.03% <0.00%> (+2.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd93a8c...b8b8d07. Read the comment docs.

@danielpacak danielpacak force-pushed the refactor_config_checkers_config branch 2 times, most recently from 0ab8e96 to 528103c Compare May 25, 2021 22:00
@danielpacak danielpacak force-pushed the refactor_config_checkers_config branch from 528103c to b8b8d07 Compare May 26, 2021 07:55
@danielpacak danielpacak merged commit ddf6f58 into main May 26, 2021
@danielpacak danielpacak deleted the refactor_config_checkers_config branch May 26, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant