fix: RBAC config when OwnerReferencesPermissionEnforcement admission controller plugin is enabled #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpacak
commented
Apr 21, 2021
| resources: | ||
| - secrets | ||
| verbs: | ||
| - delete |
There was a problem hiding this comment.
This is required because we set Job as the owner of a secret referred to by the Job spec.
Codecov Report
@@ Coverage Diff @@
## main #517 +/- ##
==========================================
- Coverage 70.93% 70.48% -0.46%
==========================================
Files 62 63 +1
Lines 4012 4028 +16
==========================================
- Hits 2846 2839 -7
- Misses 861 873 +12
- Partials 305 316 +11
Continue to review full report at Codecov.
|
…controller is enabled Resolves: #514 Signed-off-by: Daniel Pacak <[email protected]>
deven0t
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #514
Signed-off-by: Daniel Pacak [email protected]