fix: Set TRIVY_USERNAME and TRIVY_PASSWORD environment variables to consume secret keys #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpacak
force-pushed
the
fix/pass_registry_creds_as_secret_refs
branch
from
f463fb7 to
9eb74a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 43.19% 39.86% -3.33%
==========================================
Files 33 33
Lines 1623 1801 +178
==========================================
+ Hits 701 718 +17
- Misses 846 1003 +157
- Partials 76 80 +4
Continue to review full report at Codecov.
|
danielpacak
force-pushed
the
fix/pass_registry_creds_as_secret_refs
branch
from
9eb74a5 to
4691680
Compare
…onsume secret keys Signed-off-by: Daniel Pacak <[email protected]>
danielpacak
force-pushed
the
fix/pass_registry_creds_as_secret_refs
branch
from
4691680 to
1007f24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we were passing registry credentials as values. In this PR we change it to use secretKeyRefs:
Signed-off-by: Daniel Pacak [email protected]