Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5338: Remove lib/go/thrift/go.mod #2311

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Conversation

fishy
Copy link
Member

@fishy fishy commented Jan 20, 2021

Client: go

Having it under a subdirectory has some unexpected consequences, so
remove it for now. Another PR will be open up later to add it back to
the root directory.

@dcelasun
Copy link
Member

Is this related to these issues?

golang/go#34055
golang/go#33562

@fishy
Copy link
Member Author

fishy commented Jan 20, 2021

Yea kinda.

With go.mod in a subdirectory it still works, but go cannot get the correct version from git tag and this will be treated as version v0.0.0-timestamp-commitsha1

@fishy
Copy link
Member Author

fishy commented Jan 20, 2021

uh it caused some issues in the CI process. looking.

@fishy
Copy link
Member Author

fishy commented Jan 20, 2021

@dcelasun To unblock things I'm gonna change this PR to "remove go.mod" instead. I'll create another PR to add go.mod back to the root directory, but that will take longer and it does not necessarily need to be a 0.14.0 blocker.

Client: go

Having it under a subdirectory has some unexpected consequences, so
remove it for now. Another PR will be open up later to add it back to
the root directory.
@fishy fishy changed the title THRIFT-5338: Move go.mod to root directory THRIFT-5338: Remove lib/go/thrift/go.mod Jan 20, 2021
@dcelasun
Copy link
Member

Sounds good. It's probably worth delaying 0.14 for this, who knows when 0.15 will happen.

@fishy
Copy link
Member Author

fishy commented Jan 20, 2021

@dcelasun Adding go.mod back to root directory comes with some bigger issues I described in golang/go#34055 (comment). It will likely take a lot longer so we probably don't want to wait for it for 0.14.0 :)

Travis just finished. Gonna merge this one first.

@fishy fishy marked this pull request as ready for review January 20, 2021 19:49
@fishy fishy merged commit d9fcdd3 into apache:master Jan 20, 2021
@fishy fishy deleted the move-go-mod branch January 20, 2021 19:49
@dcelasun
Copy link
Member

I'll follow that thread then, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants