Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set label to column in the dataset windows. The expand-collapse icon is missing #31429

Open
2 of 3 tasks
modidim2021 opened this issue Dec 13, 2024 · 2 comments
Open
2 of 3 tasks
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed

Comments

@modidim2021
Copy link

Bug description

Cannot set label to column in the dataset windows. The expand-collapse icon is missing.
My guess is that you removed font-awesome or it is in the wrong place.

Screenshots/recordings

image

Superset version

4.1.1

Python version

3.11

Node version

I don't know

Browser

Chrome

Additional context

Docker image tag: 4.1.1-py311

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added the #bug:cosmetic Cosmetic/layout/design tweak needed label Dec 13, 2024
Copy link

dosubot bot commented Dec 13, 2024

Hello @modidim2021! I'm here to help you with your Superset issue. I can assist with bug resolution, answer questions, and guide you on becoming a contributor. Let's solve this together!

The missing expand-collapse icon issue in Superset version 4.1.1 might be related to changes in the icon libraries or their configuration. The expand-collapse icon is implemented in the file superset-frontend/src/dashboard/components/filterscope/treeIcons.jsx, and it relies on custom components and styles from react-checkbox-tree and src/components/Checkbox/CheckboxIcons [1].

If the issue is due to missing or misconfigured icon libraries, you might want to check if the necessary styles and components are correctly imported and available in your environment. Additionally, recent changes to the UI components or icon libraries, such as the commit "Add 3 new extension points for inserting custom icons" (#22027), could also be relevant [2].

Ensure that all dependencies related to icons and UI components are correctly installed and configured. The relevant dependencies in Superset version 4.1.1 include @ant-design/icons, antd, @react-icons/all-files, and others [3].

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@rusackas
Copy link
Member

I'm unable to reproduce this on current master - the toggle is fine.
image

That said, we should probably be using AntD-based components here, like we do everywhere else:
image
image
image

Maybe @kasiazjc would want to look at what else might be worth sprucing up here if we touch that component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed
Projects
None yet
Development

No branches or pull requests

2 participants