Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the minimum GraalVM CE version for compiling ShardingSphere's Native Image products to JDK 21.0.2 #29764

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Jan 18, 2024

For #29052.

Changes proposed in this pull request:

  • Updates the minimum GraalVM CE version for compiling ShardingSphere's Native Image products to JDK 21.0.2. Based on the fix in [GR-50854] Fix clinit simulation for arraycopy with null values. oracle/graal#8039, ShardingSphere can now be compiled to Native Image by GraalVM For JDK 21. Judging from the way Web Frameworks like Spring Boot handle it, we should follow the changes in GraalVM.
  • Handle the table non-existence error in https://github.com/apache/shardingsphere/actions/runs/7567041551/job/20605451778?pr=29764 . Wait for a while after executing CREATE TABLE SQL before executing INSERT SQL.
  • This PR will temporarily break the availability of shardingsphere-infra-expr-espresso. Since Truffle Espresso was refactored starting with GraalVM Truffle 23.1.0, Truffle Espresso is now available on hotspot JDK 21. This means that the module requires additional refactoring to use the Truffle API using function reflection to avoid using JDK21 bytecode at compile time.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian marked this pull request as ready for review January 18, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants