Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shardingsphere-infra-database-testcontainers optional module to unify JDBC support for testcontainers-java #29397

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

linghengqian
Copy link
Member

For #29052.

Changes proposed in this pull request:

  • Add shardingsphere-infra-database-testcontainers optional module to unify JDBC support for testcontainers-java.
  • I tend to build it into shardingsphere-jdbc-core, because the API of testcontainers-java is actually being widely used downstream.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

… unify JDBC support for testcontainers-java
@linghengqian linghengqian marked this pull request as ready for review December 13, 2023 12:53
@terrymanu terrymanu added this to the 5.4.2 milestone Dec 13, 2023
@terrymanu terrymanu merged commit 4fe1fcb into apache:master Dec 13, 2023
133 checks passed
@linghengqian linghengqian deleted the testcontainers-new branch December 13, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants