Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added strtok_s define for windows #228

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

thomas169
Copy link
Member

No description provided.

@chrisdutz
Copy link
Contributor

So this fixes a problem using the code on non-windows system? Had to do a little research to what this PR is about. A bit of context would have been helpful ;-)

@thomas169
Copy link
Member Author

Apologies, (but go easy was my first ever PR :) ). Yes allows hello world s7 to link without error on Linux

@chrisdutz
Copy link
Contributor

No worries ... I was just confused as you wrote what you did, but not why ;-)

We're always happy about getting new PRs from new folks ... so first off all: Welcome :-)

This C stuff is so fragile, that I'm a bit nervous to just merge stuff.

But it seems you added the define to windows in order to be able to use the linux variant on windows and linux, right?

Chris

@thomas169
Copy link
Member Author

Thanks, hopefully I will help out a bit more, certainly will if we start using PLC4x.

Yes, its effectively 0 change on windows (after preprocessor anyway) and a small fix on Linux

@chrisdutz
Copy link
Contributor

And ... I'm definitely no C-Pro ... so expect other "things" in there ... I'd be happy, if someone with experience would help get that thing into shape :-)

Going to merge the PR now ... thanks for contributing.

And if you haven't so-far, please subscribe to our mailinglist [email protected] (by sending an empty email to [email protected]) :-)

@chrisdutz chrisdutz merged commit 0e83ef3 into apache:develop Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants