PHOENIX-7484 Optimize mutation plan creation for upserts over tenant connection #2041
+92
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajjasani
reviewed
Dec 13, 2024
| } | ||
| } | ||
|
|
||
| private PTableRef getTableRef(PTableKey key, boolean doNotThrowTableNotFoundException) throws TableNotFoundException { |
There was a problem hiding this comment.
With this, you also mean to cover PHOENIX-7486?
There was a problem hiding this comment.
Actually, PHOENIX-7486 is a more of generic JIRA for finding and fixing other occurrences of this anti pattern. I fixed one in here as that was contributing to the regressed numbers. W/o the change in PMetadataImpl I was able to bring down regression to 30-40% from 5K-6K% but need this change to bring it down to 0.
There was a problem hiding this comment.
nit: use skipTNFE instead of doNotThrowTableNotFoundException
|
Very nice find @sanjeet006py! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upserts to multi-tenant tables over tenant connections were regressed by 5K - 6K % compared to non-tenant connections. But with this patch upserts over tenant connection are as good as non-tenant connection.