PHOENIX-7263 Row value constructor split keys not allowed on indexes #1850
+138
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoty
reviewed
Mar 8, 2024
| assertEquals("chara", rs.getString(1)); | ||
| assertEquals(4, rs.getInt(2)); | ||
| assertFalse(rs.next()); | ||
| conn.createStatement().execute("DROP INDEX " + indexName + " ON " + fullTableName); |
There was a problem hiding this comment.
Nit: We already have a stmt object. We could also create the stmt in the try-with-reources block.
| + (uncovered ? "" : " INCLUDE (long_col1, long_col2)") + (localIndex ? "" : | ||
| " SPLIT ON (" + indexSplitKeys + ")"); | ||
| stmt.execute(ddl); | ||
|
|
There was a problem hiding this comment.
We could check the regions and start keys explicitly.
I think that there is already test code for that and we'd just need to use / copy that.
| import java.sql.SQLException; | ||
| import java.util.List; | ||
|
|
||
| public class SplitKeyUtil { |
There was a problem hiding this comment.
Do we need a new Util class ?
Do we have an existing Util class that would make sense for this ?
|
The checkstyle errors also look relevant. |
|
@stoty while preparing the split keys index key constraints like order also should be considered. Will change the patch accordingly and will check whether it can be moved to existing utils. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.