Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jacoco Coverage doesn't meet specified criteria if run in release mode #1298

Open
rzo1 opened this issue Sep 13, 2024 · 3 comments
Open

Jacoco Coverage doesn't meet specified criteria if run in release mode #1298

rzo1 opened this issue Sep 13, 2024 · 3 comments
Labels

Comments

@rzo1
Copy link
Contributor

rzo1 commented Sep 13, 2024

If run in release mode

mvn release:prepare -Papache-release,apache

coverage requirements are not meet on my M3 macbook (while they seem to work correctly on GitHub actions).

This issue is created to track this behaviour.

The reason for it is, that if docker is not available (and tests are skipped), the coverage criteria is not meet and the build is failing. This should be fixed for 3.1.1 or 3.2.0.

Might be good to just put that into a profile and run that profile in CI only, so we get information about coverage or a failed build but don't get bothered while running a release on a system without docker.

@rzo1 rzo1 added the bug label Sep 13, 2024
rzo1 added a commit that referenced this issue Sep 13, 2024
@sigee
Copy link
Contributor

sigee commented Sep 20, 2024

The reason for it is, that if docker is not available (and tests are skipped), the coverage criteria is not meet and the build is failing. This should be fixed for 3.1.1 or 3.2.0.

If not all test cases are skipped and there is coverage, just not as much as in the criteria, you could decrease the threshold instead of disabling it.
But I don't understand how it relates to docker, because I could run tests without docker.

@rzo1
Copy link
Contributor Author

rzo1 commented Sep 20, 2024

Some tests aren't executed, if docker isn't available in the executing system.

rzo1 added a commit that referenced this issue Sep 23, 2024
@rzo1 rzo1 added this to the 3.1.1 milestone Sep 24, 2024
@rzo1
Copy link
Contributor Author

rzo1 commented Oct 30, 2024

Guess a solution would be to decrease the thresholds to the coverage without docker (so the testcontainer tests are not executed and do not contribute to the coverage)

@rzo1 rzo1 removed this from the 3.2.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants