Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/s3: We should respect client.region too #603

Closed
Xuanwo opened this issue Sep 5, 2024 · 1 comment · Fixed by #623
Closed

storage/s3: We should respect client.region too #603

Xuanwo opened this issue Sep 5, 2024 · 1 comment · Fixed by #623
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Sep 5, 2024

Currently, we are loading the region from s3.region. However, client.region is used in the REST catalog and Java implementation. It would be better for us to also respect client.region.
@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 8, 2024
@jdockerty
Copy link
Contributor

jdockerty commented Sep 8, 2024 •
edited
Loading

I can do this 👍

It would be better for us to also respect client.region.

If I understand rightly, the ask here to keep the s3.region within iceberg-rust and respect config.region as with the Java implementation?

Edit: I've put up a quick PR for this, feel free to suggest any changes if I've misunderstood the ask.

@jdockerty jdockerty mentioned this issue Sep 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add client.region jdockerty/iceberg-rust
2 participants
@Xuanwo @jdockerty