-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No builder for TableMetadata and no public field #52
Comments
I would also be in favor of using the builder pattern for the pub structs. If I'm correct all pub structs except for TableMetadata already have a builder. With the |
i will try to start working on it next week. Not too much spare time till now. |
Now #587 is in, I'll go ahead and close this issue 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is no way to create a new TableMetadata struct outside a deserialization operation. I don't know if it's intended but all other struct have either builder or public field.
By the way i dont see clearly a consistent way of building API struct. Sometimes there is a builder and no public field, sometimes public field and no builder and sometimes builder and public field.
To have a better visibility on this I could write, if you want, a short table summary if needed with all API struct and two column : pub field (yes/no), builder (yes/no)
The text was updated successfully, but these errors were encountered: