feat(ssr): server-side rendering and client hydration #18334 #18381

Ovilia · 2023-03-14T10:17:41Z

Brief Information

This pull request is in the type of:

bug fixing
new feature
others

What does this PR do?

See RFC at #18334 and demo.

Fixed issues

Document Info

One of the following should be checked.

This PR doesn't relate to document changes
The document should be updated later
The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

This PR depends on ZRender changes (feat(ssr): add emphasis style in ssr css apache/echarts#18334 ecomfe/zrender#999).

Related test cases or examples to use the new APIs

test/ssr.html

Others

Merging options

Please squash the commits into a single one when merging.

Other information

echarts-bot · 2023-03-14T10:17:45Z

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

echarts-bot · 2023-03-14T10:17:58Z

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

src/util/innerStore.ts

pissang · 2023-07-06T07:41:24Z

src/core/echarts.ts

+        zrender.registerSSRDataGetter(el => {
+            const ecData = getECData(el);
+            const hashMap = createHashMap();
+            hashMap.set('series_index', ecData.seriesIndex);


I will suggest returning an object in this method to ensure it will be typesafe. To avoid the situation that we change the key here and forget to change where reads it.

Do you mean we should define the type in ZRender? But ZRender should not know the structures like seriesIndex.

We can use generic type

zrender. registerSSRDataGetter<Data>(el => ...)

Just like what getECData do

ssr/client/src/index.ts

100pah

LGTM

github-actions · 2023-11-16T08:32:55Z

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18381@badfd0f

echarts-bot · 2023-11-16T08:46:54Z

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

fix a bug introduced by #18381

WIP(ssr): add meta-data and test case #18334

c1a157e

echarts-bot bot added the PR: author is committer label Mar 14, 2023

pull-request-size bot added the size/S label Mar 14, 2023

echarts-bot bot added the PR: awaiting doc Document changes is required for this PR. label Mar 14, 2023

Ovilia added 2 commits March 21, 2023 10:18

WIP

ed1c176

Merge branch 'master' into ssr

8fb7ed0

pull-request-size bot added size/M and removed size/S labels Mar 31, 2023

Ovilia added 2 commits March 31, 2023 15:32

style(ssr): remove console.log

f8b25f5

test(ssr): add test cases

27cc769

Ovilia changed the title ~~WIP(ssr): add meta-data and test case #18334~~ feat(ssr): server-side rendering and client hydration #18334 Mar 31, 2023

Ovilia marked this pull request as ready for review March 31, 2023 07:54

echarts-bot bot added the PR: awaiting review label Mar 31, 2023

100pah requested changes May 14, 2023

View reviewed changes

src/util/innerStore.ts Outdated Show resolved Hide resolved

echarts-bot bot added PR: revision needed and removed PR: awaiting review labels May 14, 2023

Ovilia added 2 commits May 31, 2023 17:15

feat(ssr): improve code

0e7eac7

feat(ssr): call registerSSRDataGetter instead of metaData

b2ff198

echarts-bot bot added PR: awaiting review and removed PR: revision needed labels Jun 13, 2023

Ovilia marked this pull request as draft June 13, 2023 11:38

echarts-bot bot removed the PR: awaiting review label Jun 13, 2023

chore(ssr): update building ssr client

a632970

pull-request-size bot added size/L and removed size/M labels Jun 26, 2023

chore(ssr): update building of ssr client

6bca132

Ovilia marked this pull request as ready for review June 27, 2023 06:21

echarts-bot bot added the PR: awaiting review label Jun 27, 2023

chore: merge

c8ba77c

Ovilia added this to the 5.5.0 milestone Jun 27, 2023

fix(ssr): remove unnecessary code

01df82a

pissang reviewed Jul 6, 2023

View reviewed changes

100pah previously approved these changes Nov 6, 2023

View reviewed changes

echarts-bot bot removed the PR: awaiting review label Nov 6, 2023

chore: merge

7dd9b37

Ovilia dismissed 100pah’s stale review via 7dd9b37 November 16, 2023 06:44

echarts-bot bot added the PR: awaiting review label Nov 16, 2023

100pah previously approved these changes Nov 16, 2023

View reviewed changes

echarts-bot bot removed the PR: awaiting review label Nov 16, 2023

chore: use zrender nightly build

badfd0f

Ovilia dismissed 100pah’s stale review via badfd0f November 16, 2023 08:26

echarts-bot bot added the PR: awaiting review label Nov 16, 2023

100pah approved these changes Nov 16, 2023

View reviewed changes

echarts-bot bot removed the PR: awaiting review label Nov 16, 2023

Ovilia merged commit b07ce79 into master Nov 16, 2023
2 checks passed

Ovilia deleted the ssr branch November 16, 2023 08:46

plainheart mentioned this pull request Jan 2, 2024

fix(ssr): remove redundant SVG attributes with undefined value #19461

Merged

8 tasks

Ovilia added a commit that referenced this pull request Jan 25, 2024

fix(ssr): hovering legend items should not trigger tooltip

e14cc9a

fix a bug introduced by #18381

Ovilia mentioned this pull request Jan 25, 2024

fix(ssr): hovering legend items should not trigger tooltip #19549

Merged

8 tasks

Ovilia added a commit to apache/echarts-handbook that referenced this pull request Feb 6, 2024

doc: add doc for ssr apache/echarts#18381

a3f570a

X-oss-byte mentioned this pull request May 25, 2024

[Snyk] Upgrade echarts from 5.4.1 to 5.5.0 X-oss-byte/mempool#84

Open

chandraguptsharma1 mentioned this pull request Jul 17, 2024

[Snyk] Upgrade echarts from 5.2.1 to 5.5.0 chandraguptsharma1/UCSHRMS#3

Open

Elenore23 mentioned this pull request Jul 20, 2024

[Snyk] Upgrade echarts from 5.5.0 to 5.5.1 Elenore23/beaconchain#5

Open

junior mentioned this pull request Jul 26, 2024

[Snyk] Upgrade echarts from 5.2.2 to 5.5.1 junior/oci-quickstart-cloudnative#225

Closed

X-oss-byte mentioned this pull request Aug 7, 2024

[Snyk] Upgrade echarts from 5.4.1 to 5.5.1 X-oss-byte/mempool#94

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ssr): server-side rendering and client hydration #18334 #18381

feat(ssr): server-side rendering and client hydration #18334 #18381

Ovilia commented Mar 14, 2023 •

edited

Loading

echarts-bot bot commented Mar 14, 2023

echarts-bot bot commented Mar 14, 2023

pissang Jul 6, 2023

Ovilia Jul 7, 2023

pissang Jul 8, 2023

100pah left a comment

github-actions bot commented Nov 16, 2023

echarts-bot bot commented Nov 16, 2023

feat(ssr): server-side rendering and client hydration #18334 #18381

feat(ssr): server-side rendering and client hydration #18334 #18381

Conversation

Ovilia commented Mar 14, 2023 • edited Loading

Brief Information

What does this PR do?

Fixed issues

Document Info

Misc

ZRender Changes

Related test cases or examples to use the new APIs

Others

Merging options

Other information

echarts-bot bot commented Mar 14, 2023

echarts-bot bot commented Mar 14, 2023

pissang Jul 6, 2023

Choose a reason for hiding this comment

Ovilia Jul 7, 2023

Choose a reason for hiding this comment

pissang Jul 8, 2023

Choose a reason for hiding this comment

100pah left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 16, 2023

echarts-bot bot commented Nov 16, 2023

Ovilia commented Mar 14, 2023 •

edited

Loading