Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add greatest(T,...) and least(T,...) SQL functions #6531

Closed
jimexist opened this issue Jun 2, 2023 · 5 comments · Fixed by #13786
Closed

Add greatest(T,...) and least(T,...) SQL functions #6531

jimexist opened this issue Jun 2, 2023 · 5 comments · Fixed by #13786
Labels
enhancement New feature or request

Comments

@jimexist
Copy link
Member

jimexist commented Jun 2, 2023

Is your feature request related to a problem or challenge?

a challenge to implement greatest and least SQL functions

Describe the solution you'd like

Similar to the 2023 standard

Describe alternatives you've considered

using if else but it is very cumbersome

Additional context

No response

@jimexist jimexist added the enhancement New feature or request label Jun 2, 2023
@jimexist jimexist changed the title Add greatest and least SQL functions Add greatest(T,...) and least(T,...) SQL functions Jun 4, 2023
@waynexia
Copy link
Member

I'd like to continue this task if you don't mind. AFAIK there isn't an obvious blocker from the history of #6527 by @jimexist and #12474 by @rluvaton.

For the topic in #12357 by @alamb, given greatest and least are both supported by PG and in the spec, adding them to the built-in function list makes sense to me.

@rluvaton
Copy link
Contributor

rluvaton commented Nov 14, 2024

I reopened my pr, can you please review my code there before I add tests?

@waynexia
Copy link
Member

Thank you @rluvaton, from the aspect of progress, I'd personally prefer to continue on #6527. But it's good that you are willing to drive your work. I've skimmed both #6527 and #12474 and both LGTM so far. Feel free to pin me after #12474 is ready for review.

@alamb
Copy link
Contributor

alamb commented Nov 24, 2024

Upate is that @rluvaton added support for greatest in

Perhaps we should file a separate ticket for least 🤔

@rluvaton
Copy link
Contributor

I'll try to add the least function in the coming week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants