Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete / integrate sqlite sqllogictest test scripts integrattion #13812

Open
alamb opened this issue Dec 17, 2024 · 3 comments
Open

Complete / integrate sqlite sqllogictest test scripts integrattion #13812

alamb opened this issue Dec 17, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Dec 17, 2024

Is your feature request related to a problem or challenge?

Part of #13811

@Omega359 has prototyped integration with the sqlite test suite ❤️

This ticket tracks the remaining work to get this runner merged into datafusion main.

Describe the solution you'd like

I would like:

  1. The runner merged into datafusion main
  2. Clear instructions on how to run the suite

Bonus points would be some way to regularly run these tests

Describe alternatives you've considered

From #13470 (comment)

I've updated my test branch with the latest changes including adding skipif for Postgresql queries that fail to run. What is left is at least 19 legitimate query result mismatches where tickets were filed.

I've submitted a PR to the sqllogictest-rs repo for my changes but so far they haven't responded. If they do not get around to merging it for whatever reason we have two choices:

  1. Rewrite the .slt files to be columnwise vs valuewise and change ordering to only be rowsort and remove the valuesort. I've actually written a lua script to handle the valuewise -> columnwise conversion, the second part will require some more work.
  2. Fork the repo and use that.

For now I'm going to slow down work on this.

Additional context

No response

@alamb
Copy link
Contributor Author

alamb commented Dec 17, 2024

@Omega359 do I have this work described correctly?

@Omega359
Copy link
Contributor

Omega359 commented Dec 17, 2024

Thanks for putting this together @alamb. Yes, the work is described correctly. CI builds currently are failing because of a clippy warning that I need to look into but otherwise it's good for others to look at.

I find that, at least on my machine, running the sqlite tests in 'normal' test mode takes ...forever. I typically run now with --release. Slower to build, faster overall.

cargo test --release --test sqllogictests -- --include-sqlite

if you do not run in release mode you may need to increase the stack size or it'll fail part way in:

export RUST_MIN_STACK=3048576

@Omega359
Copy link
Contributor

One issue that I haven't fixed is that some of the sqlite test files are LARGE. In total the files are 763M. I am unsure that we would want them in the main repo ... and I am pretty sure they will fail a CI check with some being > 1MB anyways.

Perhaps we need a new datafusion_testing repository where these files would go and be linked into df via .gitmodules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants