You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've updated my test branch with the latest changes including adding skipif for Postgresql queries that fail to run. What is left is at least 19 legitimate query result mismatches where tickets were filed.
I've submitted a PR to the sqllogictest-rs repo for my changes but so far they haven't responded. If they do not get around to merging it for whatever reason we have two choices:
Rewrite the .slt files to be columnwise vs valuewise and change ordering to only be rowsort and remove the valuesort. I've actually written a lua script to handle the valuewise -> columnwise conversion, the second part will require some more work.
Fork the repo and use that.
For now I'm going to slow down work on this.
Additional context
No response
The text was updated successfully, but these errors were encountered:
Thanks for putting this together @alamb. Yes, the work is described correctly. CI builds currently are failing because of a clippy warning that I need to look into but otherwise it's good for others to look at.
I find that, at least on my machine, running the sqlite tests in 'normal' test mode takes ...forever. I typically run now with --release. Slower to build, faster overall.
cargo test --release --test sqllogictests -- --include-sqlite
if you do not run in release mode you may need to increase the stack size or it'll fail part way in:
One issue that I haven't fixed is that some of the sqlite test files are LARGE. In total the files are 763M. I am unsure that we would want them in the main repo ... and I am pretty sure they will fail a CI check with some being > 1MB anyways.
Perhaps we need a new datafusion_testing repository where these files would go and be linked into df via .gitmodules
Is your feature request related to a problem or challenge?
Part of #13811
@Omega359 has prototyped integration with the sqlite test suite ❤️
This ticket tracks the remaining work to get this runner merged into datafusion main.
Describe the solution you'd like
I would like:
Bonus points would be some way to regularly run these tests
Describe alternatives you've considered
From #13470 (comment)
Additional context
No response
The text was updated successfully, but these errors were encountered: